Skip to content

Conversation

randomanderson
Copy link
Contributor

This pull request resolves #965 by extracting the Hystrix RxJava instrumentation logic into a separate project and replacing the Couchbase instrumentation with it.

In addition, some asynchronous couchbase tests are added.

@randomanderson randomanderson requested a review from a team as a code owner September 12, 2019 14:11
@randomanderson randomanderson added this to the 0.33.0 milestone Sep 12, 2019
Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Once you figure out the tests, you should be good to go.


def "test hasBucket #type"() {
setup:
def hasBucket = new BlockingVariable<Boolean>()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:mind_blown: I did not know about this. nice!

@randomanderson randomanderson force-pushed the landerson/couchbase-subscribe branch from 7f2091c to bccfca5 Compare September 13, 2019 00:10
@randomanderson randomanderson force-pushed the landerson/couchbase-subscribe branch from bccfca5 to 4e5e75e Compare September 13, 2019 00:52
@randomanderson randomanderson merged commit b875ae1 into master Sep 13, 2019
@randomanderson randomanderson deleted the landerson/couchbase-subscribe branch September 13, 2019 13:36
@randomanderson randomanderson restored the landerson/couchbase-subscribe branch September 13, 2019 19:01
@randomanderson randomanderson deleted the landerson/couchbase-subscribe branch September 13, 2019 22:18
@tylerbenson tylerbenson modified the milestones: 0.33.0, 0.34.0 Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Couchbase integration dropping trace

2 participants